Modify detsim to read nexus files with int instead of strings #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolafer
force-pushed
the
update-for-non-strings
branch
from
11a5a9e to
6cda61c
Compare
gonzaponte
requested changes
Apr 30, 2024
paolafer
force-pushed
the
update-for-non-strings
branch
from
d9fa6e6 to
5a597c8
Compare
gonzaponte
reviewed
May 2, 2024
paolafer
force-pushed
the
update-for-non-strings
branch
3 times, most recently
from
094dd4a to
4aa9f55
Compare
gonzaponte
approved these changes
May 3, 2024
carhc
force-pushed
the
update-for-non-strings
branch
from
4aa9f55 to
0908ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies a few functions all over the code, to deal with nexus files with
intinstead ofstringin some columns of their dataframes.The main modification is in the
detsimcity, in the selection of hits in active or buffer, but a few other functions needed to be updated, too.A test has been added to prove that the code works.
Closes #869.